Unfatal Segfaults #9663
Merged
Unfatal Segfaults #9663
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Nekotekina
requested changes
Jan 27, 2021
| } | ||
|
|
||
| report_fatal_error(msg); | ||
| thread_ctrl::emergency_exit(msg); |
There was a problem hiding this comment.
I'd recommend to be more careful with non-windows path. raise(SIGTRAP) was more tested than plain int3.
There was a problem hiding this comment.
Okay, remained unchanged for now. (until proper testing is done)
|
Well, I can't disagree that calling abort/terminate in these situations might be overkill. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Segfaults on emulation threads will not terminate RPCS3 anymore.